falcosecurity / driverkit

Kit for building Falco drivers: kernel modules or eBPF probes
Apache License 2.0
62 stars 52 forks source link

cleanup(pkg): store kernelversion inside the kernelrelease type. #301

Closed FedeDP closed 8 months ago

FedeDP commented 8 months ago

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area pkg

What this PR does / why we need it:

Since it is only used by ubuntu, avoid directly calling viper.GetString().

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
dwindsor commented 8 months ago

/approve

cc @EXONER4TED, this may affect his use case.

dwindsor commented 8 months ago

/hold

poiana commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dwindsor, EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/driverkit/blob/master/OWNERS)~~ [EXONER4TED,FedeDP,dwindsor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
EXONER4TED commented 8 months ago

/unhold