search

falcosecurity / driverkit

Kit for building Falco drivers: kernel modules or eBPF probes
Apache License 2.0
64 stars 53 forks source link

fix(pkg/driverbuilder): fixed docker container output when multiplexed. #305

Closed FedeDP closed 10 months ago

FedeDP commented 10 months ago

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area pkg

What this PR does / why we need it:

When docker container attach is called on a non-tty terminal, stray characters will appear on screen because the docker SDK uses a custom multiplexing protocol allowing STDOUT and STDERR string to be sent to a single stream. So, we now check if we are running multiplexed and adapt consequently.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
poiana commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/driverkit/blob/master/OWNERS)~~ [EXONER4TED,FedeDP] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment