fix(pkg): properly spawn bash shell in builder containers as login shells

falcosecurity / driverkit

Kit for building Falco drivers: kernel modules or eBPF probes

Apache License 2.0

62 stars 52 forks source link

fix(pkg): properly spawn bash shell in builder containers as login shells #321

Closed FedeDP closed 4 months ago

FedeDP commented 4 months ago

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build /area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP commented 4 months ago

For now, this just highlights the bug by adding a new regression test config specifically for centos 3.x that uses the driverkit-builder:centos-x86_64_gcc4.8.5-$tag image.

FedeDP commented 4 months ago

Most probably, when run by driverkit, the scl_source enable llvm-toolset-7.0 line (https://github.com/falcosecurity/driverkit/blob/master/docker/builders/builder-centos-x86_64_gcc4.8.5.Dockerfile#L37C11-L37C46) is not correctly parsed from /etc/bashrc therefore we end up with a broken environment.

poiana commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/driverkit/blob/master/OWNERS)~~ [EXONER4TED,FedeDP] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment