search

falcosecurity / driverkit

Kit for building Falco drivers: kernel modules or eBPF probes
Apache License 2.0
62 stars 52 forks source link

fix(pkg/driverbuilder): properly export KERNELDIR in kernel-download scripts #330

Closed FedeDP closed 3 months ago

FedeDP commented 3 months ago

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area pkg

What this PR does / why we need it:

Fix on top of #324 (this comment was highly specific: https://github.com/falcosecurity/driverkit/pull/324#discussion_r1524730462 :D) It also fixes vanilla kernel builds; see libs CI that is badly failing since we released driverkit v0.18.0: https://github.com/falcosecurity/libs/actions/workflows/latest-kernel.yml

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
FedeDP commented 3 months ago

/cc @EXONER4TED

FedeDP commented 3 months ago

/hold need to fix local builder.

FedeDP commented 3 months ago

/unhold fixed

FedeDP commented 3 months ago

/unhold

poiana commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/driverkit/blob/master/OWNERS)~~ [EXONER4TED,FedeDP] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment