falcosecurity / driverkit

Kit for building Falco drivers: kernel modules or eBPF probes
Apache License 2.0
64 stars 53 forks source link

new(cmd,pkg,docs,docgen,validate): switched from `slog` go library to rich-text falcoctl log library #333

Closed FedeDP closed 5 months ago

FedeDP commented 5 months ago

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area cmd /area pkg /area docs

What this PR does / why we need it:

To better integrate falcoctl and driverkit, we needed to:

Since falcoctl log library is much richer and better, i ported driverkit to use it; now each executor takes a logger parameter, that makes much easier and seamless the ingreation with falcoctl. The result is wonderful: driverkit.webm

While i was at it, i also:

TODO:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(cmd,pkg,docs,docgen,validate): switched from `slog` go library to rich-text falcoctl log library
FedeDP commented 5 months ago

Needs a rebase! Going to rebase asap!

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/driverkit/blob/master/OWNERS)~~ [EXONER4TED,FedeDP] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment