falcosecurity / driverkit

Kit for building Falco drivers: kernel modules or eBPF probes
Apache License 2.0
64 stars 53 forks source link

docs/builder.md: remove BuilderByTarget references #345

Closed nnzv closed 4 months ago

nnzv commented 4 months ago

The 'Target name' subsection is old. BuilderByTarget isn't used anymore; it's now byTarget in target.go. Add a hyperlink for clarity and accessibility.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area pkg

/area docs

What this PR does / why we need it:

The commit by @FedeDP seems to have caused this https://github.com/falcosecurity/driverkit/commit/56573f405914c2bb63b77a2bf8f0f3e64c8afde3, but it appears that the documentation hasn't been updated to match the current logic of the builders.

Which issue(s) this PR fixes:

Special notes for your reviewer:

No

Does this PR introduce a user-facing change?:

No

poiana commented 4 months ago

Welcome @nnzv! It looks like this is your first PR to falcosecurity/driverkit 🎉

nnzv commented 4 months ago

/assign FedeDP

FedeDP commented 4 months ago

Hi! Thanks for this PR! It LGTM! The commit is missing the dco though, can you fix it? https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#developer-certificate-of-origin

nnzv commented 4 months ago

The commit is missing the dco though, can you fix it? https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#developer-certificate-of-origin

Thanks for pointing that out. Didn't notice. Fixed now.

poiana commented 4 months ago

LGTM label has been added.

Git tree hash: 9db885e3ab116fab373b9f17d51bc198be254f95

poiana commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, nnzv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/driverkit/blob/master/OWNERS)~~ [FedeDP] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment