Closed nnzv closed 4 months ago
Welcome @nnzv! It looks like this is your first PR to falcosecurity/driverkit 🎉
/assign FedeDP
Hi!
Thanks for this PR! It LGTM!
The commit is missing the dco
though, can you fix it? https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#developer-certificate-of-origin
The commit is missing the dco though, can you fix it? https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#developer-certificate-of-origin
Thanks for pointing that out. Didn't notice. Fixed now.
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, nnzv
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The 'Target name' subsection is old.
BuilderByTarget
isn't used anymore; it's nowbyTarget
intarget.go
. Add a hyperlink for clarity and accessibility.What type of PR is this?
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
/area pkg
/area docs
What this PR does / why we need it:
The commit by @FedeDP seems to have caused this https://github.com/falcosecurity/driverkit/commit/56573f405914c2bb63b77a2bf8f0f3e64c8afde3, but it appears that the documentation hasn't been updated to match the current logic of the builders.
Which issue(s) this PR fixes:
Special notes for your reviewer:
No
Does this PR introduce a user-facing change?:
No