falcosecurity / driverkit

Kit for building Falco drivers: kernel modules or eBPF probes
Apache License 2.0
64 stars 53 forks source link

Builder for RHCOS #86

Closed leodido closed 1 year ago

leodido commented 3 years ago

Motivation

This comment explains well - IMHO - why the community might benefit from having a set of prebuilt Falco drivers for RHCOS.

To have such prebuilt drivers, we need a driverkit builder for RHCOS, first of all.

Feature

Create a builder for RHCOS.

poiana commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community. /close

poiana commented 3 years ago

@poiana: Closing this issue.

In response to [this](https://github.com/falcosecurity/driverkit/issues/86#issuecomment-867658316): >Rotten issues close after 30d of inactivity. > >Reopen the issue with `/reopen`. > >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Provide feedback via https://github.com/falcosecurity/community. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Tamronimus commented 1 year ago

A builder for RHCOS/RHEL 8 still would be very helpful.

Tamronimus commented 1 year ago

/reopen

poiana commented 1 year ago

@Tamronimus: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to [this](https://github.com/falcosecurity/driverkit/issues/86#issuecomment-1445211729): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
FedeDP commented 1 year ago

/reopen

poiana commented 1 year ago

@FedeDP: Reopened this issue.

In response to [this](https://github.com/falcosecurity/driverkit/issues/86#issuecomment-1445222049): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
FedeDP commented 1 year ago

A builder for RHCOS/RHEL 8 still would be very helpful.

I think you can use vanilla builder passing to it a kernel config; see for example what we do for bottlerocket with kernel-crawler: https://falcosecurity.github.io/kernel-crawler/?arch=x86_64&target=BottleRocket

dwindsor commented 1 year ago

Well, for RHEL 8, you'll need access to a system that is registered to receive RHEL entitlements. I'm not sure how it's actually working now?

FedeDP commented 1 year ago

Uh i forgot we had a redhat builder now :D it was contributed by @johnbrydon ! Gentle ping :)

dwindsor commented 1 year ago

Hahaha =)

IIUC, there's no work to be done. If you look at the example builders, there's a sample config for RHEL8 (as well as RHEL9!)

Screenshot 2023-03-02 at 9 25 31 AM

FedeDP commented 1 year ago

Oh i see; i completely forget about this :laughing: Then i think we can close this one, right?

dwindsor commented 1 year ago

I think so! yes

FedeDP commented 1 year ago

/close

poiana commented 1 year ago

@FedeDP: Closing this issue.

In response to [this](https://github.com/falcosecurity/driverkit/issues/86#issuecomment-1451957285): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.