falcosecurity / event-generator

Generate a variety of suspect actions that are detected by Falco rulesets
Apache License 2.0
94 stars 40 forks source link

wip: fix(decl): potential nil ptr deref and shell script SIGUSR handling #243

Open ekoops opened 8 hours ago

ekoops commented 8 hours ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it: This PR fixes the SIGUSR1 signal handling for shell scripts by correctly handling the exit code set by the signal (138). The first instruction after the blocking wait now verifies the returned exit code and clears its value if it matches the one set by the signal. Moreover, this PR fixes a potential nil pointer dereference in test context validation.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

poiana commented 8 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ekoops Once this PR has been reviewed and has the lgtm label, please assign fededp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/falcosecurity/event-generator/blob/declarative-testing/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment