Open ekoops opened 8 hours ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ekoops Once this PR has been reviewed and has the lgtm label, please assign fededp for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area pkg
What this PR does / why we need it: This PR fixes the
SIGUSR1
signal handling for shell scripts by correctly handling the exit code set by the signal (138). The first instruction after the blockingwait
now verifies the returned exit code and clears its value if it matches the one set by the signal. Moreover, this PR fixes a potential nil pointer dereference in test context validation.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: