falcosecurity / evolution

Evolution process of The Falco Project
Apache License 2.0
48 stars 39 forks source link

vote: update(docs): GOVERNANCE.md #215

Closed incertum closed 1 year ago

incertum commented 1 year ago

Signed-off-by: Melissa Kilby melissa.kilby.oss@gmail.com Co-authored-by: Leonardo Grasso me@leonardograsso.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind feature

/kind incubating

/kind officialsupport

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area governance

/area proposals

/area utils

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

poiana commented 1 year ago

Welcome @incertum! It looks like this is your first PR to falcosecurity/evolution 🎉

incertum commented 1 year ago

Thank you @leogr! Worked in the feedback. +1 on distinguishing between maintainers and core-maintainers criteria.

maxgio92 commented 1 year ago

Thanks @incertum! I agree with you all about to distinguish the requirements between core and non-core maintainers

leogr commented 1 year ago

Dear @falcosecurity/core-maintainers :mega:

Any change to our GOVERNANCE.md requires a supermajority vote of Core Maintainers.

So with this comment, I officially open the vote for the changes proposed by @incertum :partying_face:

The voting closes on 2022-11-24 or when we reach two thirds of votes in favor, whichever comes first. Currently, we have 12 eligible voters, so the proposal is considered successful with 8 votes in favor.

The PR will not merged until then /hold

Thanks again to @incertum for this proposal that aims to make our Governance document more precise :pray:

leogr commented 1 year ago

And ofc, +1 for me :smiley:

FedeDP commented 1 year ago

+1 for me! Thank for the proposed changes @incertum !

Andreagit97 commented 1 year ago

+1 for me :fire:

Issif commented 1 year ago

+1 for me

maxgio92 commented 1 year ago

+1 for me too

Molter73 commented 1 year ago

+1 on my side

zuc commented 1 year ago

+1 from me as well!

jasondellaluce commented 1 year ago

+1

cpanato commented 1 year ago

+1

LucaGuerra commented 1 year ago

+1

leogr commented 1 year ago

Dear @falcosecurity/core-maintainers mega

Any change to our GOVERNANCE.md requires a supermajority vote of Core Maintainers.

So with this comment, I officially open the vote for the changes proposed by @incertum partying_face

The voting closes on 2022-11-24 or when we reach two thirds of votes in favor, whichever comes first. Currently, we have 12 eligible voters, so the proposal is considered successful with 8 votes in favor.

The PR will not merged until then /hold

Thanks again to @incertum for this proposal that aims to make our Governance document more precise pray

To date, we have already obtained 10 votes, so we can officially state that this change is approved :rocket:

Thank you all :hugs:

/approve

poiana commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/evolution/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 1 year ago

LGTM label has been added.

Git tree hash: 138e9b83bdec46e07f497729062b7ebbe4281144