falcosecurity / evolution

Evolution process of The Falco Project
Apache License 2.0
47 stars 37 forks source link

Donate fededp/dbg-go to falcosecurity #316

Closed FedeDP closed 10 months ago

FedeDP commented 10 months ago

Repository:

https://github.com/FedeDP/dbg-go

Motivation

dbg-go is a swiss army knife tool to work with test-infra drivers build grid. It will allow us to completely drop driverkit folder Makefile and scripts (i already opened such a PR: https://github.com/falcosecurity/test-infra/pull/1204 that needs to fixup the fededp github user once it gets donated) replacing it with a well tested, maintained go tool.

Moreover, the go tool is also much quicker; from my benchmarks, configs generation with current bash scripts takes ~40min on my laptop for a single driver version. The dbg-go tool has a benchmark that takes ~1s to run, meaning that generating configs now takes 1s.

Also, the build command is now capable of publishing drivers while building, in an async manner. This spots 2 big benefits:

Finally, note that driverkit is now used as a library from within dbg-go; this should also speed up drivers build a bit because we avoid the overhead of spawning a new process for each driverkit config to be built, spawning a single process (dbg-go) that builds everything.

dbg-go supports same filters as old Makefile's scripts (per-target, per-kernelrelease and per-kernelversion); to glance at how it works inside test-infra, please refer to https://github.com/falcosecurity/test-infra/pull/1204

FedeDP commented 10 months ago

/cc @leogr @maxgio92 @zuc

leogr commented 10 months ago

:heart_eyes: +1 from me

count me in if you need help maintaining the project

FedeDP commented 10 months ago

count me in if you need help maintaining the project

Yes, thanks!

maxgio92 commented 10 months ago

Terrific @FedeDP! ❤️ Count me in too :)

+1

LucaGuerra commented 10 months ago

I have seen this today. This is HUGE. +1 and count me in. The more Bash+Make we can get rid of the happier I am <3 :rocket:

Andreagit97 commented 10 months ago

Wow, amazing work @FedeDP I'm looking forward to seeing it in action! Big +1 for me!

jasondellaluce commented 10 months ago

Delightful as always! +1 from me.

leogr commented 10 months ago

Hey @FedeDP

I believe nobody disagrees, so let's transfer the repo! :partying_face:

FedeDP commented 10 months ago

Let's do it once Falco 0.36.0 is out ;) Thanks everyone!

FedeDP commented 10 months ago

https://github.com/falcosecurity/dbg-go! We can close this one! The repo has also been setup on test-infra!

FedeDP commented 10 months ago

/close

poiana commented 10 months ago

@FedeDP: Closing this issue.

In response to [this](https://github.com/falcosecurity/evolution/issues/316#issuecomment-1735516545): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.