falcosecurity / falco-website

Source code of the official Falco website

https://falco.org

Creative Commons Attribution 4.0 International

35 stars 220 forks source link

create gvisor docs #1304

Closed Issif closed 5 months ago

Issif commented 6 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:

Which issue(s) this PR fixes:

1223

Fixes #

Special notes for your reviewer:

leogr commented 6 months ago

/assign @LucaGuerra

since he's the original author of the gVisor integration in Falco :)

LucaGuerra commented 6 months ago

Thank you so much for this @Issif ! I think it's important to add it to the documentation to make it easier for our adopters to run Falco with gVisor, but I'm a bit afraid that those instructions may need a couple of fixes. If they work as-is, then it's basically all good :)

LucaGuerra commented 6 months ago

@Issif did you get a chance to check this out? I can assist with helping set up the environment to run gVisor sandboxes (it's easy to do). It'd be great if you could do it following the instructions so we know if they're accurate as of today

Issif commented 6 months ago

@Issif did you get a chance to check this out? I can assist with helping set up the environment to run gVisor sandboxes (it's easy to do). It'd be great if you could do it following the instructions so we know if they're accurate as of today

I started to work on your comments, summarizing some sections and co. Still haven't found the time to test the steps, I'm preparing a talk for in 2d, I'll see after.

LucaGuerra commented 5 months ago

Thanks a lot @Issif , just a couple minor suggestions

poiana commented 5 months ago

LGTM label has been added.

Git tree hash: 73358f7eb362b324a68e58e9a47b0a53a28d9d85

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[content/OWNERS](https://github.com/falcosecurity/falco-website/blob/master/content/OWNERS)~~ [Issif,LucaGuerra] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment