search

falcosecurity / falco-website

Source code of the official Falco website
https://falco.org
Creative Commons Attribution 4.0 International
35 stars 220 forks source link

cleanup(metrics): improve prometheus and plugin metrics info #1328

Closed incertum closed 4 months ago

incertum commented 4 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:

Improve prometheus and plugin metrics info, see https://github.com/falcosecurity/falco/issues/3229

@sgaist would you mind helping with the review? Thank you!

@sboschman are these updates ok? Do you have additional input?

CC @Issif

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

sboschman commented 4 months ago

I guess the added plugin section at least tempers expectations for now. Not sure if I understand the design behind it and how it is supposed to look in the future. Will add a comment to #3194 for clarity.

poiana commented 4 months ago

@sgaist: changing LGTM is restricted to collaborators

In response to [this](https://github.com/falcosecurity/falco-website/pull/1328#pullrequestreview-2093128622): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
poiana commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, LucaGuerra, sgaist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[content/OWNERS](https://github.com/falcosecurity/falco-website/blob/master/content/OWNERS)~~ [LucaGuerra] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 4 months ago

LGTM label has been added.

Git tree hash: 7b77c8d9d3d80d525d54af64ddace00f2c3d143d