search

falcosecurity / falco

Cloud Native Runtime Security
https://falco.org
Apache License 2.0
7.16k stars 884 forks source link

Changes to package Falco into Debian #189

Closed taziden closed 5 years ago

taziden commented 7 years ago

Hello,

I'm working on packaging Falco in Debian (see #842306).

In CMakeLists.txt, there is the inclusion of directories from Sysdig :

CMakeLists.txt:#add_subdirectory("${SYSDIG_DIR}/driver" "${PROJECT_BINARY_DIR}/driver") CMakeLists.txt:#add_subdirectory("${SYSDIG_DIR}/userspace/libscap" ${PROJECT_BINARY_DIR}/userspace/libscap") CMakeLists.txt:#add_subdirectory("${SYSDIG_DIR}/userspace/libsinsp" ${PROJECT_BINARY_DIR}/userspace/libsinsp")

It would make our life way easier if these files were actually part of Falco itself. I currently don't see any other way around. Do you think it would be possible ?

Thanks, Julien

mstemm commented 7 years ago

Hi, I don't think we want to have copies of the sysdig source files in the falco repository--both sets of files are changing fairly often and I don't want to have to continually copy them over from sysdig to falco to keep them up to date.

You're right though that it's tacky to pull sysdig source files while doing the falco build. Maybe it's better to change sysdig to have a -dev build variant that has the necessary files as static libraries. Then falco could be configured to depend on the -dev sysdig build. Would that be reasonable? If so, I could start making the necessary changes for that.

taziden commented 7 years ago

Hi, I renamed the issue. I spoke with Sysdig maintainers and they think it totally makes sense to change sysdig to have a -dev build variant as you suggested. Let's go!

taziden commented 6 years ago

Any news on this one ?

mstemm commented 6 years ago

Hi, unfortunately no update yet. We might also be able to use git submodules to avoid having to do a separate git pull outside the repository, which would be a bit quicker to implement than changing sysdig to export a -dev variant with static libraries.

Let me investigate the submodule thing to see if it will work.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.