falco-driver-loader --source-only does nothing

falcosecurity / falco

Cloud Native Runtime Security

https://falco.org

Apache License 2.0

7.16k stars 884 forks source link

falco-driver-loader --source-only does nothing #2352

Closed steakunderscore closed 1 year ago

steakunderscore commented 1 year ago

Describe the bug

I believe falco-driver-loader --source-only seems like it should expose bash variables somehow. However it's current behaviour is synonymous with echo "".

How to reproduce it Call

$ scripts/falco-driver-loader --source-only

(note there's no output above)

Expected behaviour

Something like:

scripts/falco-driver-loader --source-only 
ENABLE_COMPILE=yes
ENABLE_DOWNLOAD=yes
ARCH=x86_64
KERNEL_RELEASE=5.15.0-56-generic
KERNEL_VERSION=62
DRIVERS_REPO="https://download.falco.org/driver"
DRIVER_VERSION="3.0.1+driver"
DRIVER_NAME="falco"
FALCO_VERSION="0.33.0"
DRIVER=bpf

Environment

Falco version: FALCO_VERSION="0.33.0" also can reproduce on master.

Additional context

steakunderscore commented 1 year ago

I think this is actually a misunderstanding of how bash sourcing works. I hadn't realised that calling . falco-driver-loader --source-only actually sets the environment variables in the current shell. Perhaps there's scope to update the docs for documenting how this flag can be used instead.

poiana commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana commented 1 year ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana commented 1 year ago

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community. /close

poiana commented 1 year ago

@poiana: Closing this issue.

In response to [this](https://github.com/falcosecurity/falco/issues/2352#issuecomment-1587351882): >Rotten issues close after 30d of inactivity. > >Reopen the issue with `/reopen`. > >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Provide feedback via https://github.com/falcosecurity/community. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.