falcosecurity / falcoctl

Administrative tooling for Falco
Apache License 2.0
82 stars 57 forks source link

chore(cmd/push): uniform receiver for push command #498

Closed alacuku closed 3 months ago

alacuku commented 3 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:

chore(cmd/push): uniform receiver for push command

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

alacuku commented 3 months ago

/milestone v0.8.0

poiana commented 3 months ago

@alacuku: You must be a member of the falcosecurity/falcoctl-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your maintainers of falcosecurity/falcoctl and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/falcosecurity/falcoctl/pull/498#issuecomment-2027047241): >/milestone v0.8.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
poiana commented 3 months ago

LGTM label has been added.

Git tree hash: 7c3d908bc18e2729c56a2a09ce730f563170c8ce

poiana commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/falcoctl/blob/main/OWNERS)~~ [FedeDP] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment