search

falcosecurity / falcoctl

Administrative tooling for Falco
Apache License 2.0
82 stars 57 forks source link

fix(pkg/driver): fixup kernel headers download #499

Closed FedeDP closed 3 months ago

FedeDP commented 3 months ago

What type of PR is this?

/kind bug /kind cleanup

Any specific area of the project related to this PR?

/area library

What this PR does / why we need it:

This PR fixes the templating of kernel headers download script from driverkit, that needs a fixed up kernelversion (only ubuntu uses it in driverkit, and it must be actually fixed, so that eg: #26~22.04.1 Ubuntu... becomes 26~22.04.1).

~~Moreover, it bumps driverkit to what will become v0.18.2 that contains a fix for new KERNELDIR mechanism (https://github.com/falcosecurity/driverkit/pull/330). wip until driverkit v0.18.2 is released.~~ Already in falcoctl main!

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

FedeDP commented 3 months ago

/milestone v0.8.0

FedeDP commented 3 months ago

Bumped to driverkit v0.18.2.

poiana commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/falcoctl/blob/main/OWNERS)~~ [FedeDP,leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment