search

falcosecurity / falcoctl

Administrative tooling for Falco
Apache License 2.0
82 stars 57 forks source link

fix(artifact/info): filter out signature tags #507

Closed alacuku closed 3 months ago

alacuku commented 3 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it: It does not print the signature tags for the artifacts. Before:

❯ falcoctl artifact info k8saudit
REF                                             TAGS
ghcr.io/falcosecurity/plugins/plugin/k8saudit   latest, 0, 0.5, 0.5.0, 0.5.1, 0.5.2, 0.5.3, 0.6, 0.6.0, sha256-7081acb636b9017850a4cdea58c3ecf2cde09b426da21a72fdfb434d1ff8ba76.sig, sha256-2497cdd0531d8927b736729c4d891bbc61f451445f378ceef74f212675523894.sig, sha256-1ff068506c425d8d7651758ededf02c3c35834189265c4753ad674c87504048b.sig, sha256-7c7af9315ea63dabc6c6caeeea92c084f33a1ae674e1c1b6c6c9c3825bbf054f.sig, sha256-d8d90dee3e73d02a65d2681a34e7fc7e046e2010b7427eecd3e2bbecd576bf0e.sig, 0.6.1, sha256-230dfdc0e1d331c5085f3f4c860838dcfc27f9aca8d615ce7d771ace4b621dc6.sig, 0.7, 0.7.0, sha256-14ffc5b9992947db43043a998b1e62b954f25612af553ffb252df9e3324229b1.sig, main, sha256-e6484c99a85ab8c2fc77c4efbd2102a14ce4534cf7c12ad78c30a1a5e57d87ba.sig, sha256-8e00d4c3fbc557382ca53e5a61cd5bc3b32d1ef96f403d43c3990e5d0d3ccd84.sig, sha256-58415c8dab4f2a6d3a6af6dfbf432488c8ac6792c5820f8db9d34ae2f262e49a.sig, sha256-c787c173971de583d8dd530e4d9696cf77ef38f24379ac97f8e40d1142e0fada.sig, sha256-de5045c3c905a6d811a35dd06f60cb539e6c76aba62c8e59280441584e1d5db1.sig, sha256-e0231038d62720e3e4edf9801094ac069dd0a7a77966dd8b0ed3fbcc324a2c87.sig, sha256-ce4778b4c5c6aec65dd5ef0211cd769afb275b71a99c401bf59b18886232726a.sig, sha256-6d30ef6a09377782a1003341b3cdef01e5acea5841ef57d704471216a00e1f64.sig

After:

❯ falcoctl artifact info k8saudit
REF                                             TAGS
ghcr.io/falcosecurity/plugins/plugin/k8saudit   latest, 0, 0.5, 0.5.0, 0.5.1, 0.5.2, 0.5.3, 0.6, 0.6.0, 0.6.1, 0.7, 0.7.0, main

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

poiana commented 3 months ago

LGTM label has been added.

Git tree hash: 60f1b78092c6c0b2966cb49ddec626cf937b0e91

poiana commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/falcoctl/blob/main/OWNERS)~~ [FedeDP] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
FedeDP commented 3 months ago

/milestone v0.8.0