search

falcosecurity / falcoctl

Administrative tooling for Falco
Apache License 2.0
87 stars 57 forks source link

fix: Add backend 'https' to default index #520

Closed qjoly closed 5 months ago

qjoly commented 5 months ago

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area cli

What this PR does / why we need it:

This PR will fix the issue #519 by adding the missing 'backend' field when generating the default configuration

old : 

indexes:
    - name: falcosecurity
      url: https://falcosecurity.github.io/falcoctl/index.yaml

new: 

indexes:
    - name: falcosecurity
      url: https://falcosecurity.github.io/falcoctl/index.yaml
      backend: "https"

Which issue(s) this PR fixes:

Fixes #519

huge thanks to the contributors to the Falco project and its ecosystem.

poiana commented 5 months ago

Welcome @QJoly! It looks like this is your first PR to falcosecurity/falcoctl 🎉

FedeDP commented 5 months ago

Hi! Thanks for this fix, it makes sense! /milestone v0.8.0

poiana commented 5 months ago

LGTM label has been added.

Git tree hash: 08af20e515d1ee9999751b12c76597d691e9cb7c

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, QJoly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/falcoctl/blob/main/OWNERS)~~ [FedeDP] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
FedeDP commented 5 months ago

Mmmh tide is dead i think. I will try to close and reopen this one. /close

FedeDP commented 5 months ago

/reopen

poiana commented 5 months ago

@FedeDP: Closed this PR.

In response to [this](https://github.com/falcosecurity/falcoctl/pull/520#issuecomment-2061117792): >Mmmh tide is dead i think. I will try to close and reopen this one. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
poiana commented 5 months ago

@FedeDP: Reopened this PR.

In response to [this](https://github.com/falcosecurity/falcoctl/pull/520#issuecomment-2061118250): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.