search

falcosecurity / falcoctl

Administrative tooling for Falco
Apache License 2.0
87 stars 57 forks source link

add new boolean arg for 'registry push' --add-floating-tags, it will auto add the tags for the major and the minor versions #543

Closed Issif closed 5 months ago

Issif commented 5 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:

This PR introduces a new boolean arg for registry push: --add-floating-tags. If set, with --version=1.2.3, the tags 1 and 1.2 and 1.2.3 will be added automatically, it will make easier to follow the semver.

@alacuku do you think we should also add latest with that arg or another?

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/falcoctl/blob/main/OWNERS)~~ [alacuku] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 5 months ago

LGTM label has been added.

Git tree hash: e64d54d3c29a91a034ea39b3c49148626bcab460