search

falcosecurity / falcoctl

Administrative tooling for Falco
Apache License 2.0
82 stars 57 forks source link

new(cmd/driver): driver config namespace from env variable #560

Closed FedeDP closed 1 month ago

FedeDP commented 1 month ago

What type of PR is this?

/kind bug /kind cleanup

Any specific area of the project related to this PR?

/area cli

What this PR does / why we need it:

This PR enables the namespace parameter of driver config command to be passed as FALCOCTL_DRIVER_CONFIG_NAMESPACE env variable.

Also, it fixes k8s configMap commit code, switching from Patch to Update command. Finally, logs are a little improved.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

FedeDP commented 1 month ago

/cc @alacuku

FedeDP commented 1 month ago

/milestone v0.8.0

poiana commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/falcoctl/blob/main/OWNERS)~~ [FedeDP,alacuku] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment