search

falcosecurity / falcoctl

Administrative tooling for Falco
Apache License 2.0
87 stars 57 forks source link

fix: allow login to express registry as ref but actually extract the … #610

Closed loresuso closed 2 months ago

loresuso commented 2 months ago

…registry

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it: As per PR title, allow to login with the entire ref, but actually just use the registry (pretty much like how docker login works).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

poiana commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/falcoctl/blob/main/OWNERS)~~ [alacuku] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 2 months ago

LGTM label has been added.

Git tree hash: 8809ffd1cce8c8626081508cc6734c083ca13601