Open sh4n3e opened 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sh4n3e Once this PR has been reviewed and has the lgtm label, please assign alacuku for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hey @sh4n3e, thanks for the PR.
Authentication when retrieving index files could be handy in some contexts, and I thank you for bringing this up. However, we need a simpler user experience when using authentication. Furthermore, we support different backends for index files, and the solution proposed in this PR is not flexible enough to support all the existing backends or future ones.
The command should expose three new flags:
-p, --password string index password
--password-stdin read password from stdin
-u, --username string index username
Those values should be then used for the current backend if supported.
Here is the PR that added the same feature for the authentication command: https://github.com/falcosecurity/falcoctl/pull/588
What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I have added authentication functionality for the private index. When I use private index on Enterprise Github environment (Internal/Private Repository), Exsisted Version's falcoctl is not supported.