falcosecurity / falcosidekick-ui

A simple WebUI with latest events from Falco
Apache License 2.0
113 stars 16 forks source link

fix the empty result when the value of an output field contains a dash/slash + trim prefix with the timestamp and priority for the output #136

Closed Issif closed 9 months ago

Issif commented 9 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area tests

What this PR does / why we need it:

An user noticed empty result when we search for an output field value with a / or -. It was fixed for the tags and hostnames not for other fields.

Moreover, I added a regexp to remove for the output field the timestamp + priority, it's a redundant info in the event board. It also so save some space.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

These changes will imply to flush all data, the schema in redisearch must be replaced.

poiana commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjogeleit, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/falcosidekick-ui/blob/master/OWNERS)~~ [Issif,fjogeleit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 9 months ago

LGTM label has been added.

Git tree hash: 4642ea92b0834542f2f53467b6d02bfd4e6bb3e1