search

falcosecurity / falcosidekick-ui

A simple WebUI with latest events from Falco
Apache License 2.0
113 stars 16 forks source link

fix issues #143 and #144: wrong offset when the filter has a special character and conversion error for the groupby #145

Closed Issif closed 6 months ago

Issif commented 7 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area tests

What this PR does / why we need it:

Both issues has the same root cause, the escaping was not correct for some special characters, it led to errors with the search and conversion errors with the groupby

Which issue(s) this PR fixes:

143

144

Fixes #

Special notes for your reviewer:

poiana commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjogeleit, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/falcosidekick-ui/blob/master/OWNERS)~~ [Issif,fjogeleit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 6 months ago

LGTM label has been added.

Git tree hash: aca6dfc5fe13ebe96b66fea61f3d0f7e9a533d95