search

falcosecurity / falcosidekick

Connect Falco to your ecosystem
Apache License 2.0
543 stars 176 forks source link

Follow Prometheus naming convention for falco_events metric #940

Open cezkuj opened 3 months ago

cezkuj commented 3 months ago

Motivation falco_events metric doesn't follow Prometheus naming convention causing issues with inferring its type in a monitoring system. In our case this is NewRelic Prometheus integration that uses remote write protocol. Metric is by default considered a gauge and needs manual overwrites to change its type to a counter.

Feature

Changing metric name from falco_events to falco_events_total

Additional context

I am aware that changing metric name is a breaking change, but it would be nice to have it changed at some point :)

Issif commented 3 months ago

😥 I released the 2.29.0 yesterday. Falco now exposes a Prometheus endpoint, so I wanted to remove some metrics in sidekick cause they are in double with those in Falco in 2.30. Could be the occasion to do both. I don't have any ETA