search

falcosecurity / libs

libsinsp, libscap, the kernel module driver, and the eBPF driver sources
https://falcosecurity.github.io/libs/
Apache License 2.0
213 stars 159 forks source link

Report coverage for tests #1784

Open LucaGuerra opened 3 months ago

LucaGuerra commented 3 months ago

Motivation

In the last 1~2 years we have improved test suites and coverage by a lot. If you look at libsinsp unit testing alone we went from about 6% to ~70% of the library. In addition we have the Python e2e suite and the recent C++ e2e suite, plus all driver tests that exercise single syscalls. The amount of coverage we get from all those should be maintained going forward so we should measure it and report it on PRs for each large test suite.

How to properly measure that in a way that is not misleading may be tricky and require experimentation

Alternatives

Leave it unreported. People will still add tests but maybe sometimes we won't have full context.

Additional context

poiana commented 1 week ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

Andreagit97 commented 1 week ago

/remove-lifecycle stale