falcosecurity / libs

libsinsp, libscap, the kernel module driver, and the eBPF driver sources
https://falcosecurity.github.io/libs/
Apache License 2.0
222 stars 162 forks source link

Misleading error message for plugin version check #243

Closed leogr closed 2 years ago

leogr commented 2 years ago

Motivation

Currently, when a plugin returns an empty string for its version or for the required API version, the user will get the following error message:

Could not parse version string from

In Falco, the full error line will look like this:

Tue Mar  8 17:26:15 2022: Runtime error: cannot load plugin /path/to/libsomething.so: Could not parse version string from . Exiting.

Note that my plugin returned an empty string for the required API version in those examples.

Feature

Alternatives

Doing nothing and risk a lot of headaches :smile_cat:

Additional context

Relevant code parts: https://github.com/falcosecurity/libs/blob/84470f1621d143c8cdc24fdf9bb4c5b87180ea6c/userspace/libsinsp/plugin.cpp#L366-L370

https://github.com/falcosecurity/libs/blob/84470f1621d143c8cdc24fdf9bb4c5b87180ea6c/userspace/libsinsp/plugin.cpp#L673-L677

poiana commented 2 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale