[CLEANUP] Track some modern bpf cleanups

Andreagit97 commented 1 year ago

This issue tracks some possible cleanups related to the modern BPF probe

[ ] Some refactoring highlighted by @hbrueckner during reviews (thank you for that) :) These are comments on merged PR that's the reason why it seems that we have already addressed them.
[ ] Remove libpman and use directly the scap-modern-bpf-engine. libpman was designed before the born of the "new" scap v-table approach. It was a good way to abstract the complexity of the modern probe loading from libscap, and moreover, it helped us in avoiding code duplication in the old modern bpf framework test, but now that we have a dedicated engine for the modern probe and we use directly the engines in the drivers tests, there is probably no more need for libpman. Moreover removing libpman could help us in improving the logging phase in our libraries :)

leogr commented 1 year ago

:partying_face: :balloon:

poiana commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

Andreagit97 commented 1 year ago

/remove-lifecycle stale

poiana commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

Andreagit97 commented 1 year ago

/remove-lifecycle stale

Andreagit97 commented 1 year ago

Probably these suggestions will be part of a final cleanup, when the support to all syscalls will be completed :)

leogr commented 1 year ago

Probably these suggestions will be part of a final cleanup, when the support to all syscalls will be completed :)

What's missing here?

Andreagit97 commented 1 year ago

What's missing here?

All points i would say

incertum commented 10 months ago

Now only libpman cleanup pending?

leogr commented 10 months ago

cc @Andreagit97 ?

Andreagit97 commented 10 months ago

nope we miss all the points here

poiana commented 7 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

Andreagit97 commented 7 months ago

/remove-lifecycle stale

leogr commented 7 months ago

@Andreagit97 do you plan to work on this?

(if so please /assign it to yourself :pray: )

poiana commented 4 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

incertum commented 4 months ago

/remove-lifecycle stale

leogr commented 4 months ago

@Andreagit97 what's missing here?

Andreagit97 commented 4 months ago

all the points in the issue!

leogr commented 4 months ago

all the points in the issue!

got it. Sorry, all those merged icons misled me to think there was some progress.

poiana commented 1 month ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

Andreagit97 commented 1 month ago

/remove-lifecycle stale

falcosecurity / libs

[CLEANUP] Track some modern bpf cleanups #593