update: make logger more resilient and performant

falcosecurity / plugin-sdk-cpp

Falco plugins SDK for C++

Apache License 2.0

3 stars 10 forks source link

update: make logger more resilient and performant #37

Closed jasondellaluce closed 8 months ago

jasondellaluce commented 8 months ago

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area plugin-sdk

What this PR does / why we need it:

The falcosecurity::logger API has been improved to always inline methods, to support const char* strings, and to avoid segfaults if initialized with no callback.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update: make logger more resilient and performant

poiana commented 8 months ago

LGTM label has been added.

Git tree hash: a37b5528d89ec4f8ff08969440f1f65b3e8b3024

poiana commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-cpp/blob/master/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment