search

falcosecurity / plugin-sdk-cpp

Falco plugins SDK for C++
Apache License 2.0
3 stars 10 forks source link

new: update SDK to plugin API version 3.6.0 #38

Closed mrgian closed 4 months ago

mrgian commented 5 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

incertum commented 4 months ago

Tagging myself here to know when this gets merged.

mrgian commented 4 months ago

Minor points to be solved before merging

I solved these points but please don't merge this for now.

I've tried running this example for a while https://github.com/mrgian/plugin-sdk-cpp/blob/update-3.6.0-new/examples/syscall_parse/plugin.cpp And it looks like repeated subtable writes are causing a segfault. I'm investigating to see if the issue lies in the libs or the SDK 👀

mrgian commented 4 months ago

And it looks like repeated subtable writes are causing a segfault. I'm investigating to see if the issue lies in the libs or the SDK 👀

After investigating the issue with @jasondellaluce, looks like the the issue is on the libs side. This PR should be ready to be merged :)

@incertum I also added a new example showing how to access the args and the fd_table from the event TID. If the example is not clear enough please let me know :)

@jasondellaluce the example has a lot of prints, should we keep it as is or should we remove them before merging?

poiana commented 4 months ago

LGTM label has been added.

Git tree hash: 4e71d0d6997a520e57ebf14865b3b6a5bed3249b

poiana commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, mrgian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-cpp/blob/master/OWNERS)~~ [FedeDP] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment