falcosecurity / plugin-sdk-cpp

Falco plugins SDK for C++
Apache License 2.0
3 stars 10 forks source link

fix: release table_entry with the move operator and add default constructor for table_entry #39

Closed therealbobo closed 3 months ago

therealbobo commented 3 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:

The table_entry class was missing the default constructor. The table_entry move operator didn't clean up the left hand side table_entry when moving

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

poiana commented 3 months ago

@therealbobo: The label(s) kind/design cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/falcosecurity/plugin-sdk-cpp/pull/39): > > >**What type of PR is this?** > >> Uncomment one (or more) `/kind <>` lines: > >/kind bug > >> /kind cleanup > >/kind design > >> /kind documentation > >> /kind failing-test > >> /kind feature > >**Any specific area of the project related to this PR?** > >> Uncomment one (or more) `/area <>` lines: > >> /area build > >> /area plugin-sdk > >> /area tests > > > >**What this PR does / why we need it**: > >The `table_entry` class was missing the default constructor. >The `table_entry` move operator didn't clean up the left hand side `table_entry` when moving > >**Which issue(s) this PR fixes**: > > > >Fixes # > >**Special notes for your reviewer**: > >**Does this PR introduce a user-facing change?**: > > > >```release-note > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
poiana commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mstemm, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-cpp/blob/master/OWNERS)~~ [mstemm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 3 months ago

LGTM label has been added.

Git tree hash: 5e974c99c30e68c93fee1bf92ae6b10390768deb