search

falcosecurity / plugin-sdk-cpp

Falco plugins SDK for C++
Apache License 2.0
3 stars 10 forks source link

new: bump plugin API to 3.10.0. #41

Open FedeDP opened 3 weeks ago

FedeDP commented 3 weeks ago

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area plugin-sdk

What this PR does / why we need it:

Plugin API 3.8.0 introduced support for suggested output formats in extractor plugins; support it. https://github.com/falcosecurity/libs/pull/2116

Plugin API 3.9.0 introduced support for exposing get_owner_last_error in capture listening capability. https://github.com/falcosecurity/libs/pull/2147

Plugin API 3.10.0 introduced support for new async capability related dump API. https://github.com/falcosecurity/libs/pull/2152

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
FedeDP commented 3 weeks ago

/hold because we are relying upon a development libs version that is not supported by latest Falco.

FedeDP commented 1 week ago

Will need to bump tp 3.9.0 after https://github.com/falcosecurity/libs/pull/2147 is merged

FedeDP commented 1 week ago

Will bump to 3.10.0 once https://github.com/falcosecurity/libs/pull/2152 is merged :D

poiana commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-cpp/blob/master/OWNERS)~~ [FedeDP] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-cpp/blob/master/OWNERS)~~ [FedeDP] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
FedeDP commented 1 week ago

I pushed a commit without DCO because it relies on https://github.com/falcosecurity/libs/pull/2152 HEAD hash. Will make sure to amend it once that PR is merged. I pushed it to give an idea of what the new dump API would look like.

leogr commented 3 days ago

/check-dco

poiana commented 3 days ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
leogr commented 3 days ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • eb80c81 new: bump plugin API to 3.10.0.

cc @FedeDP

FedeDP commented 3 days ago

https://github.com/falcosecurity/plugin-sdk-cpp/pull/41#issuecomment-2464680381 @leogr