search

falcosecurity / plugin-sdk-go

Falco plugins SDK for Go
Apache License 2.0
26 stars 17 forks source link

Divorce plugin rcs from libscap rcs #15

Closed mstemm closed 3 years ago

mstemm commented 3 years ago

Change the values to only those that are relevant for plugins. The plugin framework keeps the values separate and converts when necessary.

Signed-off-by: Mark Stemm mark.stemm@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
poiana commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-go/blob/main/OWNERS)~~ [leogr,mstemm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 3 years ago

LGTM label has been added.

Git tree hash: 0bfcc2869309afc669beadcd47b7988cb87b4e50

leogr commented 3 years ago

/kind design

leogr commented 3 years ago

/check-dco

leogr commented 3 years ago

/close

poiana commented 3 years ago

@leogr: Closed this PR.

In response to [this](https://github.com/falcosecurity/plugin-sdk-go/pull/15#issuecomment-945624578): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
leogr commented 3 years ago

/reopen

poiana commented 3 years ago

@leogr: Reopened this PR.

In response to [this](https://github.com/falcosecurity/plugin-sdk-go/pull/15#issuecomment-945624682): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.