search

falcosecurity / plugin-sdk-go

Falco plugins SDK for Go
Apache License 2.0
26 stars 17 forks source link

update: add accessor for field type in ExtractRequest #19

Closed jasondellaluce closed 3 years ago

jasondellaluce commented 3 years ago

Signed-off-by: Jason Dellaluce jasondellaluce@gmail.com

What type of PR is this?

/kind design

/kind feature

Any specific area of the project related to this PR?

/area plugin-sdk

What this PR does / why we need it: This adds the FieldType() accessor to the sdk.ExtractRequest interface. This is useful in field extraction to implement type-based reasoning and to potentially achieve better performance.

Without this accessor, plugin developers need to maintain knowledge about the type of each supported field across multiple code parts, which leads to a more verbose and dirty codebase.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
poiana commented 3 years ago

Hi @jasondellaluce. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
leogr commented 3 years ago

/ok-to-test

poiana commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-go/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 3 years ago

LGTM label has been added.

Git tree hash: 244c63be198e1a76c2d9951a5af85220eb2deebf