search

falcosecurity / plugin-sdk-go

Falco plugins SDK for Go
Apache License 2.0
26 stars 17 forks source link

Use uint64_t to prevent long/longlong confusion #28

Closed LucaGuerra closed 3 years ago

LucaGuerra commented 3 years ago

Signed-off-by: Luca Guerra luca@guerra.sh

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:

When attempting to compile a plugin on MacOS the process will fail because of an error like ../../../../go/pkg/mod/github.com/falcosecurity/plugin-sdk-go@v0.0.0-20211105150954-f1111dfdc937/pkg/sdk/event.go:173:9: cannot use _Ctype_ulong(_Ciconst_UINT64_MAX) (type _Ctype_ulong) as type _Ctype_ulonglong in assignment If you change that as the error suggests, you'll get the opposite error on Linux. This fixes the behavior by mapping those uint64_t fields to the C.uint64_t type.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(sdk): fixed _Ctype_ulong / _Ctype_ulonglong assignment errors when trying to compile on MacOS
poiana commented 3 years ago

Welcome @LucaGuerra! It looks like this is your first PR to falcosecurity/plugin-sdk-go 🎉

poiana commented 3 years ago

Hi @LucaGuerra. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
leogr commented 3 years ago

/ok-to-test

poiana commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-go/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 3 years ago

LGTM label has been added.

Git tree hash: 38e3aa65900dfd1f9712af90619209f0f3eb2f9a