search

falcosecurity / plugin-sdk-go

Falco plugins SDK for Go
Apache License 2.0
26 stars 17 forks source link

update(sdk)!: support list field types according to API version 1.0.0 #42

Closed jasondellaluce closed 2 years ago

jasondellaluce commented 2 years ago

Signed-off-by: Jason Dellaluce jasondellaluce@gmail.com

What type of PR is this?

/kind design

/kind feature

Any specific area of the project related to this PR?

/area plugin-sdk

/area tests

What this PR does / why we need it:

This PR follows up the recent developments in https://github.com/falcosecurity/libs/pull/201 that add support for field types that extract list of values.

As the major the plugin API version changed, this PR brings some breaking changes due to some changes in the contract of the plugin_extract_fields symbol.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(sdk)!: support list field types according to plugin API version 1.0.0
jasondellaluce commented 2 years ago

This is now rebased to the latest libs version and should be ready for review

leogr commented 2 years ago

PS

It would be nice to add a section about performance to this document and discourage plugin authors to return list with more than 512 items.

poiana commented 2 years ago

LGTM label has been added.

Git tree hash: 0c788e4e7d10aff5160129c9b103cfa5c282e6de

poiana commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-go/blob/main/OWNERS)~~ [jasondellaluce,leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment