falcosecurity / plugin-sdk-go

Falco plugins SDK for Go
Apache License 2.0
26 stars 17 forks source link

update(sdk): Export plugin_extract_fields on Windows. #46

Closed geraldcombs closed 2 years ago

geraldcombs commented 2 years ago

Make sure we set the dllexport attribute on plugin_extract_fields when we're building for Windows.

Signed-off-by: Gerald Combs gerald@wireshark.org

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:

It ensures that plugin_extract_fields is callable on Windows.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
poiana commented 2 years ago

Welcome @geraldcombs! It looks like this is your first PR to falcosecurity/plugin-sdk-go 🎉

poiana commented 2 years ago

Hi @geraldcombs. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
leogr commented 2 years ago

/ok-to-test

poiana commented 2 years ago

LGTM label has been added.

Git tree hash: 050bc94542d5a123048c2930bd8b2c90ba2e9990

poiana commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geraldcombs, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-go/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
geraldcombs commented 2 years ago

I'm assuming we don't need __declspec(dllexport) for other symbols because CGO already takes care of that.

That appears to be the case. This was the only export missing when comparing the output of dumpbin /exports on Windows with nm on macOS.