Closed geraldcombs closed 2 years ago
Welcome @geraldcombs! It looks like this is your first PR to falcosecurity/plugin-sdk-go 🎉
Hi @geraldcombs. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geraldcombs, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I'm assuming we don't need
__declspec(dllexport)
for other symbols because CGO already takes care of that.
That appears to be the case. This was the only export missing when comparing the output of dumpbin /exports
on Windows with nm
on macOS.
Make sure we set the dllexport attribute on plugin_extract_fields when we're building for Windows.
Signed-off-by: Gerald Combs gerald@wireshark.org
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area plugin-sdk
What this PR does / why we need it:
It ensures that plugin_extract_fields is callable on Windows.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: