search

falcosecurity / plugin-sdk-go

Falco plugins SDK for Go
Apache License 2.0
26 stars 17 forks source link

Feature: Added a job in ci which builds the all examples #83

Closed GLVSKiriti closed 4 months ago

GLVSKiriti commented 7 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #77

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
poiana commented 7 months ago

Welcome @GLVSKiriti! It looks like this is your first PR to falcosecurity/plugin-sdk-go 🎉

GLVSKiriti commented 7 months ago

@jasondellaluce @leogr As mentioned in the issue I implemented the first task

Can you please give me guidance on how to implement the second task

Run the example plugins with a given Falco version (maybe the last released one + dev?) so that we can catch trivial bugs in the SDK

leogr commented 7 months ago

/assign @leogr /assign @jasondellaluce

poiana commented 4 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

leogr commented 4 months ago

/remove-lifecycle stale

poiana commented 4 months ago

LGTM label has been added.

Git tree hash: 1e6a4ab74eaf8ca6f1a075425b9479cb5594ffff

poiana commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GLVSKiriti, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-go/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment