falcosecurity / plugins

Falco plugins registry
Apache License 2.0
82 stars 75 forks source link

chore: update `dummy_c` to use the latest c++ plugin SDK version #377

Closed Andreagit97 closed 9 months ago

Andreagit97 commented 9 months ago

What type of PR is this?

/kind failing-test

Any specific area of the project related to this PR?

/area plugins

What this PR does / why we need it:

Currently, dev plugins are not released when a PR is merged in master. This is the error

Mon Oct 30 14:06:43 2023: Falco version: 0.35.1 (x86_64)
Mon Oct 30 14:06:43 2023: CLI args: /usr/bin/falco -o json_output=true -V ./tmp_rules.yaml -c /__w/plugins/plugins/plugins/dummy_c/falco.yaml -o log_level=debug -o log_stderr=true -o log_syslog=false -o stdout_output.enabled=true
Mon Oct 30 14:06:43 2023: Falco initialized with configuration file: /__w/plugins/plugins/plugins/dummy_c/falco.yaml
Mon Oct 30 14:06:43 2023: Loading plugin 'dummy_c' from file /usr/share/falco/plugins/libdummy_c.so
Mon Oct 30 14:06:43 2023: Runtime error: cannot load plugin /usr/share/falco/plugins/libdummy_c.so: plugin required API version '2.0.0' not compatible with the framework's API version '3.0.0': major versions disagree. Exiting.

To fix this I bumped the dummy_c plugin to use the latest API provided by the c++ plugin SDK.

Which issue(s) this PR fixes:

Special notes for your reviewer:

github-actions[bot] commented 9 months ago

Rules files suggestions

Andreagit97 commented 9 months ago

I will update the dummy plugin to the latest framework API version

github-actions[bot] commented 9 months ago

Rules files suggestions

Rules files suggestions

poiana commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/master/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 9 months ago

LGTM label has been added.

Git tree hash: 287e1903907843e7fdd555ef66bd364962b70851