search

falcosecurity / plugins

Falco plugins registry
Apache License 2.0
82 stars 75 forks source link

Add `k8smeta` plugin to the plugin repo #378

Closed Andreagit97 closed 9 months ago

Andreagit97 commented 9 months ago

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area plugins

What this PR does / why we need it:

This PR adds the k8smeta plugin to the plugin repo.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Andreagit97 commented 9 months ago

This PR is still a draft but i need the CI to check the integration of the plugin, so i cannot mark it as a draft

Andreagit97 commented 9 months ago

The plugin repo could be another great candidate for https://github.com/falcosecurity/falco/pull/2945, since from now for the k8smeta plugin we will build grpc on QEMU for arm64 :/ it takes almost 1h and 33 m

Andreagit97 commented 9 months ago

I have disabled codeQL for cpp in the "general" CI job, probably i will add a specific codeQL job for the k8smeta plugin and the dummy_c one

github-actions[bot] commented 9 months ago

Rules files suggestions

Andreagit97 commented 9 months ago

I will split the actual cpp codeQL workflow into single plugin jobs for k8smeta and dummy_c

github-actions[bot] commented 9 months ago

Rules files suggestions

github-advanced-security[bot] commented 9 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-actions[bot] commented 9 months ago

Rules files suggestions

github-actions[bot] commented 9 months ago

Rules files suggestions

github-actions[bot] commented 9 months ago

Rules files suggestions

github-actions[bot] commented 9 months ago

Rules files suggestions

leogr commented 9 months ago

/assign

github-actions[bot] commented 9 months ago

Rules files suggestions

poiana commented 9 months ago

LGTM label has been added.

Git tree hash: 50f7993b0ba7253900afade5f6b9b139aa9c2de4

poiana commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/master/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment