falcosecurity / plugins

Falco plugins registry
Apache License 2.0
82 stars 75 forks source link

add refresh_interval parameter #383

Closed Issif closed 8 months ago

Issif commented 9 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

This PR introduces a new parameter refresh_interval to avoid Too many requests from the Okta API. It also introduces a deduplication of the keys to count the MFA attempts.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

github-actions[bot] commented 9 months ago

Rules files suggestions

okta_rules.yaml

Comparing d3c1bf68334f13815641bd7c66f20c930457889c with latest tag okta-0.8.1

No changes detected

leogr commented 9 months ago

/assign

fdriouch commented 8 months ago

Hi everyone, I deeply appreciate your valuable contributions to this project. Would it be possible to prioritize reviewing and approving this PR? This would be immensely helpful as the issue this PR fixes is causing several daily false positives in our alerting system.

Thank you so much for your dedication.

fdriouch commented 8 months ago

Hi @jasondellaluce, @leogr, do you have any ETA in mind for reviewing this PR? Thanks!

poiana commented 8 months ago

LGTM label has been added.

Git tree hash: d96a303721bf43a892a3c837515b2dc13a4c5533

poiana commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/master/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment