search

falcosecurity / plugins

Falco plugins registry
Apache License 2.0
85 stars 77 forks source link

fix(ci): fix remote tag deletion/skipping #401

Closed LucaGuerra closed 9 months ago

LucaGuerra commented 9 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

What this PR does / why we need it:

The remote build would show erratic behavior when a 0.10.0 tag was introduced. This was possibly due to git ordering of tags. Instead of relying on it we'll use a set, remove what we don't need and later sort with semver.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

leogr commented 9 months ago

The remote build would show erratic behavior when a 0.10.0 tag was introduced. This was possibly due to git ordering of tags. Instead of relying on it we'll use a set, remove what we don't need and later sort with semver.

Make sense. For example:

❯ git --no-pager tag --list "okta-[0-9].*" --contains okta-0.8.0
okta-0.10.0
okta-0.8.0
okta-0.8.1
okta-0.9.0
poiana commented 9 months ago

LGTM label has been added.

Git tree hash: 57986e9eafcc755bccdd83f1a21c71e242420534

poiana commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/master/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment