LucaGuerra commented 7 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

What this PR does / why we need it:

After #373 was merged every plugin with rules needs a version bump because OCI rules will not be able to be followed in Falco versions < 0.37.0 (to be released this month). This PR bumps every version. Specifically:

k8saudit-0.7.0
cloudtrail-0.10.0
dummy-0.10.0
github-0.7.0
gcpaudit-0.3.0
k8saudit-eks-0.4.0

This ensures we do not break existing downloads and follows for older Falco versions

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

github-actions[bot] commented 7 months ago

Rules files suggestions

github.yaml

Comparing ceee91b8a72011b60daa0a16c1c9200ff2bdb338 with latest tag github-0.6.1

No changes detected

gcp_auditlog_rules.yaml

Comparing ceee91b8a72011b60daa0a16c1c9200ff2bdb338 with latest tag gcpaudit-0.2.2

Major changes:

Rule GCP IAM principle modified has been removed
Rule GCP backendService deleted has been removed
Rule GCP Pub/Sub Subscriber modified has been removed
Rule GCP IAM serviceAccount created has been removed
Rule GCP IAM serviceAccount modified has been removed
Rule GCP IAM serviceAccount deleted has been removed
Rule GCP cloud function updated or deleted has been removed
Rule GCP IAM serviceAccount key created has been removed
Rule GCP IAM serviceAccount key deleted has been removed
Rule GCP KMS updated or deleted has been removed

Minor changes:

Version dependency to plugin gcpaudit has been incremented
Rule GCP logging sink deleted has been added
Rule GCP IAM service account deleted has been added
Rule GCP IAM policy modified has been added
Rule GCP Pub/Sub subscription deleted has been added
Rule GCP IAM service account created has been added
Rule GCP IAM service account key created has been added
Rule GCP KMS deleted has been added
Rule GCP backend service deleted has been added
Rule GCP IAM service account modified has been added
Rule GCP KMS updated has been added
Rule GCP Pub/Sub subscription modified has been added
Rule GCP IAM service account key deleted has been added
Rule GCP cloud function deleted has been added
Rule GCP cloud function modified has been added

aws_cloudtrail_rules.yaml

Comparing ceee91b8a72011b60daa0a16c1c9200ff2bdb338 with latest tag cloudtrail-0.9.1

No changes detected

github.yaml

Comparing ceee91b8a72011b60daa0a16c1c9200ff2bdb338 with latest tag github-0.6.1

No changes detected

gcp_auditlog_rules.yaml

Comparing ceee91b8a72011b60daa0a16c1c9200ff2bdb338 with latest tag gcpaudit-0.2.2

Major changes:

Rule GCP IAM principle modified has been removed
Rule GCP backendService deleted has been removed
Rule GCP Pub/Sub Subscriber modified has been removed
Rule GCP IAM serviceAccount created has been removed
Rule GCP IAM serviceAccount modified has been removed
Rule GCP IAM serviceAccount deleted has been removed
Rule GCP cloud function updated or deleted has been removed
Rule GCP IAM serviceAccount key created has been removed
Rule GCP IAM serviceAccount key deleted has been removed
Rule GCP KMS updated or deleted has been removed

Minor changes:

Version dependency to plugin gcpaudit has been incremented
Rule GCP logging sink deleted has been added
Rule GCP IAM service account deleted has been added
Rule GCP IAM policy modified has been added
Rule GCP Pub/Sub subscription deleted has been added
Rule GCP IAM service account created has been added
Rule GCP IAM service account key created has been added
Rule GCP KMS deleted has been added
Rule GCP backend service deleted has been added
Rule GCP IAM service account modified has been added
Rule GCP KMS updated has been added
Rule GCP Pub/Sub subscription modified has been added
Rule GCP IAM service account key deleted has been added
Rule GCP cloud function deleted has been added
Rule GCP cloud function modified has been added

github-actions[bot] commented 7 months ago

Rules files suggestions

aws_cloudtrail_rules.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag cloudtrail-0.9.1

Minor changes:

Version dependency to plugin cloudtrail has been incremented

github.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag github-0.6.1

Minor changes:

Version dependency to plugin github has been incremented

gcp_auditlog_rules.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag gcpaudit-0.2.2

Major changes:

Rule GCP IAM serviceAccount key created has been removed
Rule GCP Pub/Sub Subscriber modified has been removed
Rule GCP IAM serviceAccount modified has been removed
Rule GCP IAM serviceAccount key deleted has been removed
Rule GCP backendService deleted has been removed
Rule GCP IAM serviceAccount created has been removed
Rule GCP cloud function updated or deleted has been removed
Rule GCP IAM serviceAccount deleted has been removed
Rule GCP IAM principle modified has been removed
Rule GCP KMS updated or deleted has been removed

Minor changes:

Version dependency to plugin gcpaudit has been incremented
Rule GCP IAM policy modified has been added
Rule GCP KMS updated has been added
Rule GCP KMS deleted has been added
Rule GCP logging sink deleted has been added
Rule GCP IAM service account key deleted has been added
Rule GCP Pub/Sub subscription deleted has been added
Rule GCP IAM service account key created has been added
Rule GCP cloud function deleted has been added
Rule GCP backend service deleted has been added
Rule GCP IAM service account modified has been added
Rule GCP cloud function modified has been added
Rule GCP Pub/Sub subscription modified has been added
Rule GCP IAM service account deleted has been added
Rule GCP IAM service account created has been added

okta_rules.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag okta-0.10.0

Minor changes:

Version dependency to plugin okta has been incremented

aws_cloudtrail_rules.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag cloudtrail-0.9.1

Minor changes:

Version dependency to plugin cloudtrail has been incremented

github.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag github-0.6.1

Minor changes:

Version dependency to plugin github has been incremented

gcp_auditlog_rules.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag gcpaudit-0.2.2

Major changes:

Rule GCP IAM serviceAccount key created has been removed
Rule GCP Pub/Sub Subscriber modified has been removed
Rule GCP IAM serviceAccount modified has been removed
Rule GCP IAM serviceAccount key deleted has been removed
Rule GCP backendService deleted has been removed
Rule GCP IAM serviceAccount created has been removed
Rule GCP cloud function updated or deleted has been removed
Rule GCP IAM serviceAccount deleted has been removed
Rule GCP IAM principle modified has been removed
Rule GCP KMS updated or deleted has been removed

Minor changes:

Version dependency to plugin gcpaudit has been incremented
Rule GCP IAM policy modified has been added
Rule GCP KMS updated has been added
Rule GCP KMS deleted has been added
Rule GCP logging sink deleted has been added
Rule GCP IAM service account key deleted has been added
Rule GCP Pub/Sub subscription deleted has been added
Rule GCP IAM service account key created has been added
Rule GCP cloud function deleted has been added
Rule GCP backend service deleted has been added
Rule GCP IAM service account modified has been added
Rule GCP cloud function modified has been added
Rule GCP Pub/Sub subscription modified has been added
Rule GCP IAM service account deleted has been added
Rule GCP IAM service account created has been added

okta_rules.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag okta-0.10.0

Minor changes:

Version dependency to plugin okta has been incremented

aws_cloudtrail_rules.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag cloudtrail-0.9.1

Minor changes:

Version dependency to plugin cloudtrail has been incremented

github.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag github-0.6.1

Minor changes:

Version dependency to plugin github has been incremented

gcp_auditlog_rules.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag gcpaudit-0.2.2

Major changes:

Rule GCP IAM serviceAccount key created has been removed
Rule GCP Pub/Sub Subscriber modified has been removed
Rule GCP IAM serviceAccount modified has been removed
Rule GCP IAM serviceAccount key deleted has been removed
Rule GCP backendService deleted has been removed
Rule GCP IAM serviceAccount created has been removed
Rule GCP cloud function updated or deleted has been removed
Rule GCP IAM serviceAccount deleted has been removed
Rule GCP IAM principle modified has been removed
Rule GCP KMS updated or deleted has been removed

Minor changes:

Version dependency to plugin gcpaudit has been incremented
Rule GCP IAM policy modified has been added
Rule GCP KMS updated has been added
Rule GCP KMS deleted has been added
Rule GCP logging sink deleted has been added
Rule GCP IAM service account key deleted has been added
Rule GCP Pub/Sub subscription deleted has been added
Rule GCP IAM service account key created has been added
Rule GCP cloud function deleted has been added
Rule GCP backend service deleted has been added
Rule GCP IAM service account modified has been added
Rule GCP cloud function modified has been added
Rule GCP Pub/Sub subscription modified has been added
Rule GCP IAM service account deleted has been added
Rule GCP IAM service account created has been added

okta_rules.yaml

Comparing 4c1d6368b802bf5c4101ec76d045465b732f224c with latest tag okta-0.10.0

Minor changes:

Version dependency to plugin okta has been incremented

poiana commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/master/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

poiana commented 7 months ago

LGTM label has been added.

Git tree hash: 7a62045cb15cdc51960c800b87332ab2211f73ff

Andreagit97 commented 7 months ago

probably we need to bump also k8smeta https://github.com/falcosecurity/plugins/blob/e1047e145de8d0eb225468adf7940c7acb0e882e/plugins/k8smeta/src/shared_with_tests_consts.h#L80

leogr commented 7 months ago

probably we need to bump also k8smeta

https://github.com/falcosecurity/plugins/blob/e1047e145de8d0eb225468adf7940c7acb0e882e/plugins/k8smeta/src/shared_with_tests_consts.h#L80

I agree. what about 0.1.0 ? Feel free to open the PR. We will git tag all plugins on monday

Andreagit97 commented 7 months ago

done here https://github.com/falcosecurity/plugins/pull/404

falcosecurity / plugins

chore(plugins): bump versions for Falco 0.37.0 #403

Rules files suggestions

Rules files suggestions

github.yaml

gcp_auditlog_rules.yaml

aws_cloudtrail_rules.yaml

github.yaml

gcp_auditlog_rules.yaml

Rules files suggestions

Rules files suggestions

Rules files suggestions

Rules files suggestions

aws_cloudtrail_rules.yaml

github.yaml

gcp_auditlog_rules.yaml

okta_rules.yaml

aws_cloudtrail_rules.yaml

github.yaml

gcp_auditlog_rules.yaml

okta_rules.yaml

aws_cloudtrail_rules.yaml

github.yaml

gcp_auditlog_rules.yaml

okta_rules.yaml