falcosecurity / plugins

Falco plugins registry
Apache License 2.0
82 stars 75 forks source link

Add a walkthrough for the GCP Plugin #408

Closed mikegcoleman closed 7 months ago

mikegcoleman commented 7 months ago

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

/area plugins /area documentation

What this PR does / why we need it: This walkthrough should help people use the plugin more easily

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

github-actions[bot] commented 7 months ago

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing 7d89876eeddc7e8696b8d8fe238f42b24a5aab19 with latest tag gcpaudit-0.3.0

No changes detected

leogr commented 7 months ago

cc @ahmedameenaim @jasondellaluce

github-actions[bot] commented 7 months ago

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing ba8f314a1e801a3504458fc535d38b300826e593 with latest tag gcpaudit-0.3.0

No changes detected

mikegcoleman commented 7 months ago
  • you describe the installation on the host, can you also create a section for an installation via Helm in a GKE cluster, seems to be the Create codeql-analysis.yml #1 installation method

@Issif For the walkthrough we're not using a Kubernetes cluster. We could definitely add that to the docs, but I don't want to put too much into the walkthrough.

Would that work?

github-actions[bot] commented 7 months ago

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing 76f8722b5bd703942c91aec9dc92cf7058ee333a with latest tag gcpaudit-0.3.0

No changes detected

poiana commented 7 months ago

LGTM label has been added.

Git tree hash: d3de19bdef3fffac1572b8294a524eb89e1b20a7

poiana commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, mikegcoleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[plugins/gcpaudit/OWNERS](https://github.com/falcosecurity/plugins/blob/master/plugins/gcpaudit/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment