search

falcosecurity / plugins

Falco plugins registry
Apache License 2.0
85 stars 77 forks source link

fix(pkg/oci): trim spaces when handling required_engine_version #411

Closed loresuso closed 8 months ago

loresuso commented 8 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

Properly trim spaces and parse the required engine version.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

poiana commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/master/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 8 months ago

LGTM label has been added.

Git tree hash: d4929d49090eeaff34e815d572b2732389f0feb6