search

falcosecurity / plugins

Falco plugins registry
Apache License 2.0
80 stars 73 forks source link

Fix application name extraction issue #428

Closed fdriouch closed 5 months ago

fdriouch commented 5 months ago

What type of PR is this?

/kind bug

/kind documentation

Any specific area of the project related to this PR?

/area plugins

/area documentation

What this PR does / why we need it:

We need it to capture the application alternate ID (which is more explicit than application name) and populate that information in alerts to make them more actionable.

Which issue(s) this PR fixes:

Fixes #427

Special notes for your reviewer:

This is my first PR for this project don't hesitate to provide feedback on "what could have been better". Thanks.

/cc @Issif

poiana commented 5 months ago

Welcome @fdriouch! It looks like this is your first PR to falcosecurity/plugins 🎉

github-actions[bot] commented 5 months ago

Rules files suggestions

okta_rules.yaml

Comparing 4ccd3c1abe605f889401a118ec5b7f98f673d5f5 with latest tag okta-0.10.0

Minor changes:

github-actions[bot] commented 5 months ago

Rules files suggestions

okta_rules.yaml

Comparing 20bf1b0739d3160a28334c346b54117cfc6630ba with latest tag okta-0.10.0

Minor changes:

poiana commented 5 months ago

LGTM label has been added.

Git tree hash: 7b3f009b44db03f007bb144693f8608de7074a81

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fdriouch, Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[plugins/okta/OWNERS](https://github.com/falcosecurity/plugins/blob/master/plugins/okta/OWNERS)~~ [Issif,leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment