falcosecurity / plugins

Falco plugins registry
Apache License 2.0
80 stars 73 forks source link

refactor(cloudtrail): Get S3 keys concurrently #429

Closed uhei closed 5 months ago

uhei commented 5 months ago

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area plugins

What this PR does / why we need it:

To speed up the process of getting all the keys, divide the inputParams array into chunks and get the keys for each item in the chunk concurrently.

Special notes for your reviewer:

This should be my last commit for the time being. This means that version 0.12 can be released (after testing by third parties).

github-actions[bot] commented 5 months ago

Rules files suggestions

aws_cloudtrail_rules.yaml

Comparing 41f76ab773ddcdc9bda0c32893a0a1c6b14b12b2 with latest tag cloudtrail-0.11.0

No changes detected

leogr commented 5 months ago

cc @LucaGuerra @Issif

github-actions[bot] commented 5 months ago

Rules files suggestions

aws_cloudtrail_rules.yaml

Comparing 00bc8c17a2a50c53995f2114d83634a5ccceaa4a with latest tag cloudtrail-0.11.0

No changes detected

poiana commented 5 months ago

LGTM label has been added.

Git tree hash: 5f7c416ca4b0ce1820b10a181c94ab5f748de484

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr, uhei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/master/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment