falcosecurity / plugins

Falco plugins registry

Apache License 2.0

80 stars 73 forks source link

vote: add Issif as owner of the okta plugin for the PR approvals #430

Closed Issif closed 5 months ago

Issif commented 5 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

I'm the developer of this plugin, seems fair to me to be allowed to approve the PR from the community, especially because I'm still continue to develop/answer the issue/review the PR.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

github-actions[bot] commented 5 months ago

Rules files suggestions

okta_rules.yaml

Comparing 068f6f6a5f15deb677bad85036d2f063a9cd0fa6 with latest tag okta-0.10.0

Minor changes:

Version dependency to plugin okta has been incremented

leogr commented 5 months ago

This is a majority vote as per our governance.

/hold until we get majority or a week has passed

leogr commented 5 months ago

and ofc big +1 from me :)

jasondellaluce commented 5 months ago

+1 @Issif! Thanks for the help.

poiana commented 5 months ago

LGTM label has been added.

Git tree hash: a574d253ea36fc7e5264f9942d5bc036188c2f19

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/master/OWNERS)~~ [leogr,mstemm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment