falcosecurity / plugins

Falco plugins registry
Apache License 2.0
80 stars 73 forks source link

cleanup(rules): remove dangling references to lists, lint #431

Closed LucaGuerra closed 5 months ago

LucaGuerra commented 5 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

What this PR does / why we need it:

Some rules in the k8s_audit set were referencing lists present in falco_rules and falco_sandbox_rules sets. I believe it is risky to keep them like this because we introduce a dependency on something that is optional. While it's true that if you have both rulesfiles loaded you probably want those lists to be the same, we cannot assume that you will always have falco_rules loaded if you are using k8s audit and we need to leave this choice to the user.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

github-actions[bot] commented 5 months ago

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing 9f055538322473c410bb633de5cb7e4454a9856e with latest tag gcpaudit-0.3.0

No changes detected

k8s_audit_rules.yaml

Comparing 9f055538322473c410bb633de5cb7e4454a9856e with latest tag k8saudit-eks-0.4.0

Minor changes:

github-actions[bot] commented 5 months ago

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing 8785ede33eeb5b765fb377a6dea1daf716612049 with latest tag gcpaudit-0.3.0

No changes detected

k8s_audit_rules.yaml

Comparing 8785ede33eeb5b765fb377a6dea1daf716612049 with latest tag k8saudit-eks-0.4.0

Minor changes:

Patch changes:

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing 8785ede33eeb5b765fb377a6dea1daf716612049 with latest tag gcpaudit-0.3.0

No changes detected

k8s_audit_rules.yaml

Comparing 8785ede33eeb5b765fb377a6dea1daf716612049 with latest tag k8saudit-eks-0.4.0

Minor changes:

Patch changes:

LucaGuerra commented 5 months ago

@leogr sure, updated!

github-actions[bot] commented 5 months ago

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing 82301365ec730d614376c11a7207819b5195c89f with latest tag gcpaudit-0.3.0

No changes detected

k8s_audit_rules.yaml

Comparing 82301365ec730d614376c11a7207819b5195c89f with latest tag k8saudit-eks-0.4.0

Major changes:

Minor changes:

Patch changes:

Rules files suggestions

gcp_auditlog_rules.yaml

Comparing 82301365ec730d614376c11a7207819b5195c89f with latest tag gcpaudit-0.3.0

No changes detected

k8s_audit_rules.yaml

Comparing 82301365ec730d614376c11a7207819b5195c89f with latest tag k8saudit-eks-0.4.0

Major changes:

Minor changes:

Patch changes:

github-actions[bot] commented 5 months ago

Rules files suggestions

github-actions[bot] commented 5 months ago

Rules files suggestions

poiana commented 5 months ago

LGTM label has been added.

Git tree hash: 5db0473f6bd9a4a99c6e153023168690dc99be62

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/master/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment