falcosecurity / plugins

Falco plugins registry
Apache License 2.0
80 stars 73 forks source link

vote: add sboschman as approver for k8saudit-gke, and add the plugin to the registry #437

Closed sboschman closed 5 months ago

sboschman commented 5 months ago

@Issif or @leogr , as we handed out plugin id 16 for k8saudit-gke, it might be useful to list it in the plugins readme

Issif commented 5 months ago

The list of plugins is auto-generated from the registry.yaml. See the other entries as examples and update it, then run make update-readme.

BTW, as the original author of the plugin, I would recommend you to create an OWNER file at the root of the plugin, like this one https://github.com/falcosecurity/plugins/blob/master/plugins/k8saudit-eks/OWNERS, it will allow you to review/approve futures PR.

cc @leogr @jasondellaluce @mstemm

github-actions[bot] commented 5 months ago

Rules files suggestions

poiana commented 5 months ago

LGTM label has been added.

Git tree hash: e3f8f18508af6906760d23338ec5d26b4448923c

leogr commented 5 months ago

We got the majority and also week has passed, so /unhold

Welcome on board @sboschman :clap:

We will take care of the procedure to set up your account as a maintainer. cc @FedeDP @LucaGuerra

@sboschman meanwhile, could I just ask you to add yourself to this file?

leogr commented 5 months ago

N.B. @sboschman you get an GitHub invitation to the falcosecurity organization once this PR gets merged.

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr, sboschman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/master/OWNERS)~~ [jasondellaluce,leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
leogr commented 5 months ago

/verify-owners